Thanks for your quick reply Hanover, this definitely answers my question and solves my problem. I owe you one, let me know if you need any help in excel or VBA.
ZM
- #142
- Aug 20, 2013 1:36pm Aug 20, 2013 1:36pm
- Joined Sep 2009 | Status: Making Code While Making Pips | 1,672 Posts
hello. attached custom indicator (HourlyMovement) displays the number of pips that price moves for each hour for the past days as so -
i tried the List Object Details script but it did not give me the data i want. it only identified the text (0, 1, 2 ... 23 hours label) and not even the bars.
what i would like to get is the maximum and minimum of each bar/hour without using the data window and pointing on each of them to get the values everytime i wish to trade.
would very much appreciate your help. thanks.
i tried the List Object Details script but it did not give me the data i want. it only identified the text (0, 1, 2 ... 23 hours label) and not even the bars.
what i would like to get is the maximum and minimum of each bar/hour without using the data window and pointing on each of them to get the values everytime i wish to trade.
would very much appreciate your help. thanks.
- #155
- Edited 8:56am Jan 11, 2014 8:36am | Edited 8:56am
- | Joined Jan 2014 | Status: Trader | 14 Posts
That's right. The init() part covers here: the indicator buffers, index buffers, and the pair names' assignment to the corresponding strings. Is there still missing something? Well, I don't know, but I don't think so, because I've seen many exporting indicators with a very scant init() section. I also suppose that deinit() should also be ignored (although I'm not 100% sure).
Thanks for your effort and your helpful approach, anyway.
My last question would be: which part of that code invokes your greatest suspicion, because I will keep searching for that bug by myself until I find it or rewrite it. :nerd:
Thanks for your effort and your helpful approach, anyway.
My last question would be: which part of that code invokes your greatest suspicion, because I will keep searching for that bug by myself until I find it or rewrite it. :nerd:
FF
- #156
- Jan 11, 2014 9:44am Jan 11, 2014 9:44am
- Joined Sep 2006 | Status: ... | 8,112 Posts
That's right. The init() part covers here: the indicator buffers, index buffers, and the pair names' assignment to the corresponding strings. Is there still missing something? Well, I don't know, but I don't think so, because I've seen many exporting indicators with a very scant init() section. I also suppose that deinit() should also be ignored (although I'm not 100% sure). Thanks for your effort and your helpful approach, anyway.
- #157
- Edited 11:11am Jan 11, 2014 11:00am | Edited 11:11am
- | Joined Jan 2014 | Status: Trader | 14 Posts
Wow! I have finally managed to make it work.
What I did is:
1) I introduced the handle in variable part, before the init() like that:
// File identificator
int handle;
2) I moved this part of code to init()
//----
if (Comments)
Comment("Starting data export...");
if (OutputFile == "")
OutputFile = "FXDataExport.csv";
handle = FileOpen(OutputFile,FILE_CSV|FILE_WRITE,",");
if(handle < 1) {
Comment("Unable to open the output file");
return(0);
}
3) I put it in deinit():
// Close the file
FileClose(handle);
4) I left the file-refreshing code in start():
if (prev_time != iTime(Symbol(),tfr,0)) {
prev_time = iTime(Symbol(),tfr,0); }
5) as well as (in start()) the multi-pair loop and FileWrite() command, but I resigned from the void() block at all - just let the code run from start(), not void().
And now it works upon the initiation of MT4 (after a few seconds, as soon as it downloads the data from server)! I'm not sure, if all of these changes were necessary, but some of it was for sure.
The last thing that remains to be verified after these modifications is, if the exported file will be refreshed at the completion of the tfr bar, as the fx markets are closed at the moment. It's important to me, but we'll see it tomorrow night. Thanks for cooperation again, Hanover.
What I did is:
1) I introduced the handle in variable part, before the init() like that:
// File identificator
int handle;
2) I moved this part of code to init()
//----
if (Comments)
Comment("Starting data export...");
if (OutputFile == "")
OutputFile = "FXDataExport.csv";
handle = FileOpen(OutputFile,FILE_CSV|FILE_WRITE,",");
if(handle < 1) {
Comment("Unable to open the output file");
return(0);
}
3) I put it in deinit():
// Close the file
FileClose(handle);
4) I left the file-refreshing code in start():
if (prev_time != iTime(Symbol(),tfr,0)) {
prev_time = iTime(Symbol(),tfr,0); }
5) as well as (in start()) the multi-pair loop and FileWrite() command, but I resigned from the void() block at all - just let the code run from start(), not void().
And now it works upon the initiation of MT4 (after a few seconds, as soon as it downloads the data from server)! I'm not sure, if all of these changes were necessary, but some of it was for sure.
The last thing that remains to be verified after these modifications is, if the exported file will be refreshed at the completion of the tfr bar, as the fx markets are closed at the moment. It's important to me, but we'll see it tomorrow night. Thanks for cooperation again, Hanover.
FF
- #158
- Jan 11, 2014 11:08am Jan 11, 2014 11:08am
- Joined Sep 2006 | Status: ... | 8,112 Posts
Wow! I have finally managed to make it work........
And many thanks for the info.