Attachments: I will code your EAs and Indicators for no charge

I will code your EAs and Indicators for no charge

#1,681
Feb 25, 2013 1:39pm Feb 25, 2013 1:39pm

RaptorUK
Joined Jan 2008 | Status: Trader | 870 Posts

Quoting 786 trading

Disliked

I need help in coding issue. I am trying to write a script which will read a csv file and will draw horizontal lines from the file.
question 1: when i use FileReadString it gives me complete one line like EURUSD,1.3250,Red
then I use StringSubstr to extract EURUSD and 1.3250 and Red separately. Is that correct there is no way directly that I can get one by one comma separated values for one line/record?

Problem 2: I need price 1.325 to use horizontal line which require double value.
When I convert it to double var=StrToDouble("priceVar");...

Ignored

I think you are getting mixed up, a string may have trailing zeros like 1.52300000 a double will be 1.532

Why don't you simply read your file as a CSV file ?

20 pips a day isn't too much to ask . . .

#1,682
Edited 2:27pm Feb 25, 2013 2:10pm | Edited 2:27pm

786 trading
| Joined Oct 2007 | Status: Student | 603 Posts

Quoting RaptorUK

Disliked

Why don't you simply read your file as a CSV file ?

Ignored

That would be nice if I can direct read it as csv, any example please. I am new to this coding.
Thanks.

Quoting RaptorUK

Disliked

I think you are getting mixed up, a string may have trailing zeros like 1.52300000 a double will be 1.532

Ignored

I am pasting the code. I am pasting csv file and then code which is reading and trying to draw line:
Thanks:

mydata.vsv
--------------------
EURUSD,1.32459,Red
----------------

int start()
{
int Handle;
int fCounter;
color Col;
double entry;
string line_title;
string hd_line_title;
string Text;

Handle=FileOpen("ala.csv",FILE_CSV|FILE_READ,';');
if(Handle > 0)
{
hd_line_title = "H-Line";
fCounter = 1;
while(FileIsEnding(Handle)==false)
{
Text =FileReadString(Handle);
string sym = StringSubstr(Text,0,6) ;
string subText = StringSubstr(Text,7,StringLen(Text)-1) ;
int posComa=StringFind(subText, ",", 0);
string strPrice = StringSubstr(subText,0,posComa) ;
string DoubleToStrPrice = DoubleToStr(NormalizeDouble(strPrice,5),4);
string lineDesc = StringSubstr(subText,posComa+1,StringLen(subText)-1) ;

Print("Text=" + Text + " sumble:" + sumble + " price="+DoubleToStrPrice+"lineDesc=" + lineDesc ,AccountName()); // this display price=1.3245900000
line_title = sumble + ":" + lineDesc + " " + fCounter;
Col = White;
// Entry Line
ObjectCreate(line_title, OBJ_HLINE, 0, 0, NormalizeDouble( StrToDouble( DoubleToStrPrice),4));
ObjectSet(line_title, OBJPROP_COLOR, Col); // Buy line
ObjectSet(line_title, OBJPROP_WIDTH, 1);
ObjectSet(line_title, OBJPROP_STYLE, STYLE_SOLID);
fCounter++;
}

Edit: Please let me know what is mistake in the code? As I told you that I just want to read from csv file and draw lines of that values.

#1,683
Feb 25, 2013 2:36pm Feb 25, 2013 2:36pm

kis
Joined Dec 2011 | Status: Trader | 364 Posts

Quoting FxSignals

Disliked

errors:

2013.02.25 21:51:53 elvis2(1) EURUSD,H1: Error opening short position: 129
2013.02.25 21:51:53 elvis2(1) EURUSD,H1: Long position opened: 1454977171
2013.02.25 21:51:53 elvis2(1) EURUSD,H1: open #1454977171 buy 0.10 EURUSD at 1.31771 sl: 1.30771 tp: 1.31871 ok
2013.02.25 21:51:48 elvis2(1) EURUSD,H1: Error opening short position: 129
2013.02.25 21:51:48 elvis2(1) EURUSD,H1: Error opening long position: 6
2013.02.25 21:51:22 elvis2(1) EURUSD,H1: initialized

i have just 1 buy position now

Ignored

Well, check this: http://docs.mql4.com/constants/errors
ERR_NO_CONNECTION6No connection with trade server.
ERR_INVALID_PRICE129Invalid price.

Try the attached one. If there is error, will try to send order again in 5 sec, then if it is error again, retry in 5 sec.

Attached File(s)

elvis2.ex4 8 KB | 427 downloads

Keep It Simple

#1,684
Feb 25, 2013 9:00pm Feb 25, 2013 9:00pm

786 trading
| Joined Oct 2007 | Status: Student | 603 Posts

I think I am getting problem with NormalizeDouble. When a I convert string to double, it ads lot of zeros at the end and NormalizeDouble should remove extra zeros but it is not doing that.
Any one have idea why I have issue with NormalizeDouble ? Is there any alternate to that in MQL4.

The example of code is here ---------------

string strPrice = "1.2345";
double dPrice = NormalizeDouble(StrToDouble(strPrice),5);
Print("$$$=step 2 priceLevel = " + dPrice ,AccountName());

#1,685
Feb 25, 2013 9:21pm Feb 25, 2013 9:21pm

mpradeep
| Joined Apr 2012 | Status: Trader | 168 Posts

Quoting kis

Disliked

Well, check this: http://docs.mql4.com/constants/errors
ERR_NO_CONNECTION6No connection with trade server.
ERR_INVALID_PRICE129Invalid price.

Try the attached one. If there is error, will try to send order again in 5 sec, then if it is error again, retry in 5 sec.

Ignored

Hi brother

can u code a Ea on this strategy. I am doing manually in H4 getting good result.
http://forex-strategies-revealed.com/mt4/swingstrategy
Thank you

#1,686
Edited 9:56pm Feb 25, 2013 9:29pm | Edited 9:56pm

nubcake
Joined Oct 2009 | Status: . | 4,038 Posts

Quoting 786 trading

Disliked

I think I am getting problem with NormalizeDouble. When a I convert string to double, it ads lot of zeros at the end and NormalizeDouble should remove extra zeros but it is not doing that.
Any one have idea why I have issue with NormalizeDouble ? Is there any alternate to that in MQL4.

The example of code is here ---------------

string strPrice = "1.2345";
double dPrice = NormalizeDouble(StrToDouble(strPrice),5);
Print("$$$=step 2 priceLevel = " + dPrice ,AccountName());

Ignored

what the fuck?

1. normalizedouble does not 'remove zeros'. it does nothing of the sort, and there just isn't enough energy in me to explain to you what it actually does and someone new to coding is not in a position to even comprehend what it does. just know that you need to use it sometimes... so use it.

2. the 'number of zeros' in your double has no relevance to setting an objects values. look in the journal to see what errors you are getting!

3. your other post shows a clusterfuck of code that is all kinds of broken, and it's not even formatted within code tags for us to read it properly.

4. what... the fuck... are you doing? since you didn't format it within code tags i'm not about to go about fixing it up for you... so :

Text =FileReadString(Handle);
string sym = StringSubstr(Text,0,6) ;

string subText = StringSubstr(Text,7,StringLen(Text)-1) ; <--- why stringlen of text - 1? that's just wrong. it will work... but it's still wrong. the third parameter, if supplied, is a LENGTH value... not an ending index value.

int posComa=StringFind(subText, ",", 0);
string strPrice = StringSubstr(subText,0,posComa) ; <--- hey, don't forget that this is a string

string DoubleToStrPrice = DoubleToStr(NormalizeDouble(strPric e,5),4); <--- nope. you already forgot that strPrice is a string.... NOT a double. you can't DoubleToStr something that is already a string, or in this case NormalizeDouble something that is a string. If the compiler doesn't complain and let's this pass then you are getting erroneous values. This is surely where your most major problem is.

5. the way you are chopping-up your text bit by bit is also just plain bad and inelegant. stringfind has a starting index value you can provide it.... use that to start searching your string for your next comma from one index position AFTER the last known comma... then use these now known start and end index positions to supply stringsubstr with a start and (calculated) length value.

...

that's all just horrible. badly named vars that don't even contain the values you mean them to contain. no wonder it's not working. i'm surprised if it even compiles, though i can see why it would compile but be completely broken.

go back to the help file and read about filereading. reading data from a csv file is already taken care of within mql. you just have to use the correct file access and the correct reading function while supplying the string variables you want to be fed the 'cell' data from the character separated values file each time you read a line.

Congratulations ScalaFX for coming out of the closet!

#1,687
Feb 26, 2013 12:05am Feb 26, 2013 12:05am

FxSignals
| Joined Mar 2009 | Status: Trader | 124 Posts

Quoting kis

Disliked

Well, check this: http://docs.mql4.com/constants/errors
ERR_NO_CONNECTION 6 No connection with trade server.
ERR_INVALID_PRICE 129 Invalid price.

Try the attached one. If there is error, will try to send order again in 5 sec, then if it is error again, retry in 5 sec.

Ignored

in this version, after first 2 order, no any order + no error

#1,688
Edited 9:53am Feb 26, 2013 1:09am | Edited 9:53am

786 trading
| Joined Oct 2007 | Status: Student | 603 Posts

Quoting nubcake

Disliked

what the fuck?

1. normalizedouble does not 'remove zeros'. it does nothing of the sort, and there just isn't enough energy in me to explain to you what it actually does and someone new to coding is not in a position to even comprehend what it does. just know that you need to use it sometimes... so use it.

2. the 'number of zeros' in your double has no relevance to setting an objects values. look in the journal to see what errors you are getting!

3. your other post shows a clusterfuck of code that is all kinds of broken, and it's not...

Ignored

Sorry to make you angry, I did not mean that someone fixed my code. What happen that once my code did not work as I expect then I was trying to display variable values using Print.. to see at what stage string gets lot of zeros.. and my mistake that I had that code in email and I pasted it as it is without deleting it as I was on job. I apologize for that.

But I am thankful to you that you still explain and correct the code.
I will read help and try to refine my code as you advised.

But I would like to say that you should "mind your language", I appreciate that you are helping people and I have lot of respect for this great work, so this kind of words and language does not suite to you."

The only function I am looking is to convert string var="1.34663" to double var2=1.34663, do not want zeros at the end.
If I use strtodouble() function it is adding zeros at the end.
May be still I am wrong.
Anyway I thank you again all of you guys for help.

#1,689
Feb 26, 2013 7:38am Feb 26, 2013 7:38am

kis
Joined Dec 2011 | Status: Trader | 364 Posts

Quoting FxSignals

Disliked

in this version, after first 2 order, no any order + no error

Ignored

Hi,

I tested it again today, and it works for me, however, I made some changes again. What broker are you using?
Here are few things to check:
1. Once you put EA on the chart, don't change time frames, because EA will be reinitialized.
2. Don't change account history period.
3. If MT4 was closed, and there are still open positions from this EA when you re-open MT4, you need to wait those positions to close or close them manually, EA will not open new positions until old one as closed.
4. Make sure, other EA is not using the same magic number.

Attached File(s)

elvis_final.ex4 7 KB | 551 downloads

Keep It Simple

#1,690
Feb 26, 2013 7:48am Feb 26, 2013 7:48am

kis
Joined Dec 2011 | Status: Trader | 364 Posts

Quoting mpradeep

Disliked

Hi brother

can u code a Ea on this strategy. I am doing manually in H4 getting good result.
http://forex-strategies-revealed.com/mt4/swingstrategy
Thank you

Ignored

Hi,

Since how long are you testing it? What are the results? What was the maximum DD?

Keep It Simple

#1,691
Feb 26, 2013 9:19am Feb 26, 2013 9:19am

~bull.bear~
Joined Sep 2012 | Status: Aim Consistent Income | 791 Posts

Quoting kis

Disliked

Hi,

Since how long are you testing it? What are the results? What was the maximum DD?

Ignored

I personally don't think is a good result, since I did many test for the same scenario (Open Long & short order at same price or different price level with grid, and different RR). what I know buylimit and selllimit orders would be the best after I test 8 years but little profit. Other test gives bad result, the reason is due to bad RR ratio, couldn't make it for many years.

Thanks.

#1,692
Feb 26, 2013 9:43am Feb 26, 2013 9:43am

kis
Joined Dec 2011 | Status: Trader | 364 Posts

Quoting ~bull.bear~

Disliked

I personally don't think is a good result, since I did many test for the same scenario (Open Long & short order at same price or different price level with grid, and different RR). what I know buylimit and selllimit orders would be the best after I test 8 years but little profit. Other test gives bad result, the reason is due to bad RR ratio, couldn't make it for many years.

Thanks.

Ignored

Thanks.

Keep It Simple

#1,693
Feb 26, 2013 9:45am Feb 26, 2013 9:45am

rast
| Joined Jun 2009 | Status: Trader | 13 Posts

Hi, am looking for a MACD indicator that will alert me when there divergences....

Thank you in advance.

#1,694
Feb 26, 2013 11:13am Feb 26, 2013 11:13am

nubcake
Joined Oct 2009 | Status: . | 4,038 Posts

Quoting 786 trading

Disliked

Sorry to make you angry, I did not mean that someone fixed my code. What happen that once my code did not work as I expect then I was trying to display variable values using Print.. to see at what stage string gets lot of zeros.. and my mistake that I had that code in email and I pasted it as it is without deleting it as I was on job. I apologize for that.

But I am thankful to you that you still explain and correct the code.
I will read help and try to refine my code as you advised.

But I would like to say that you should "mind your language",...

Ignored

you can take the advice or you can ignore it. i'm not here to be nice to you, or be your friend, or "mind my language". if you don't like it then stick me on ignore and get help from some other muppet. you aren't in a position to critique me. know your place, and fix your code. spend less time worrying about people being nice to you and you might learn something new.

Inserted Code

#property indicator_separate_window

int init() {}
int deinit() {}

int start() {
  int Handle;
  int fCounter;
  color Col;
  double entry;
  string line_title;
  string hd_line_title;
  string Text;
  
//  Handle=FileOpen("ala.csv",FILE_CSV| FILE_READ,';');
  //if(Handle > 0) {
    hd_line_title = "H-Line";
    fCounter = 1;
    //while(FileIsEnding(Handle)==false) {
      //Text =FileReadString(Handle);
      Text = "EURUSD,1.32459,Red";
      string sym = StringSubstr(Text,0,6) ;
      string subText = StringSubstr(Text,7,StringLen(Text)-1) ;
      int posComa = StringFind(subText, ",", 0);
      string strPrice = StringSubstr(subText,0,posComa) ;
      string DoubleToStrPrice = DoubleToStr(NormalizeDouble(strPrice,5),4);
      string lineDesc = StringSubstr(subText,posComa+1,StringLen(subText)-1) ;
      
      Print("Text=" + Text + " price="+DoubleToStrPrice + " lineDesc= " + lineDesc); // this display price=1.3245900000
//      line_title = sumble + ":" + lineDesc + " " + fCounter;
      Col = White;
      // Entry Line
//      ObjectCreate(line_title, OBJ_HLINE, 0, 0, NormalizeDouble( StrToDouble( DoubleToStrPrice),4));
  //    ObjectSet(line_title, OBJPROP_COLOR, Col); // Buy line
    //  ObjectSet(line_title, OBJPROP_WIDTH, 1);
      //ObjectSet(line_title, OBJPROP_STYLE, STYLE_SOLID);
      fCounter++;
//    }
  //}
}

2013.02.27 03:06:04 testingotherscodeindi EURUSD,M1: Text=EURUSD,1.32459,Red price=0.0000 lineDesc= Red
2013.02.27 03:02:56 testingotherscodeindi EURUSD,M1: invalid double number as parameter 1 for NormalizeDouble function

as i said, the string being passed is wrong, and the journal shows this... something you should be seeing in your journal as well. the price being reported, however, does not match what you suggest is being reported, so i suspect you aren't even being honest with us about what you are getting as a result.

Congratulations ScalaFX for coming out of the closet!

#1,695
Feb 26, 2013 11:51am Feb 26, 2013 11:51am

RaptorUK
Joined Jan 2008 | Status: Trader | 870 Posts

Quoting 786 trading

Disliked

Edit: Please let me know what is mistake in the code? As I told you that I just want to read from csv file and draw lines of that values.

Ignored

Doesn't this explain it all ?

string strPrice = StringSubstr(subText,0,posComa) ;

string DoubleToStrPrice = DoubleToStr( NormalizeDouble( strPrice, 5) ,4);

Why are you calling NormalizeDouble() with a string ?

20 pips a day isn't too much to ask . . .

#1,696
Feb 26, 2013 2:08pm Feb 26, 2013 2:08pm

786 trading
| Joined Oct 2007 | Status: Student | 603 Posts

Quoting nubcake

Disliked

you can take the advice or you can ignore it. i'm not here to be nice to you, or be your friend, or "mind my language". if you don't like it then stick me on ignore and get help from some other muppet. you aren't in a position to critique me. know your place, and fix your code. spend less time worrying about people being nice to you and you might learn something new.

[code]
#property indicator_separate_window

int init() {}
int deinit() {}

int start() {
int Handle;
int fCounter;
color Col;
double entry;
string line_title;...

Ignored

Thanks for help. My code is running now.
int init() {}
int deinit() {}
int Handle;
string Text;

int start() {
// csv file
//EURUSD,1.34347,Red
Print("----------------- Start --------------");
color Col = Red;
string val;
string line_title_prefix = "line_title_";
string line_title;
int iCount = 1;
Handle=FileOpen("ala.csv",FILE_CSV| FILE_READ,';');
if(Handle > 0) {
while(FileIsEnding(Handle)==false && iCount < 10) {
line_title = line_title_prefix + iCount;
iCount++;
Text =FileReadString(Handle);
string sym = StringSubstr(Text,0,6) ;
val = StringSubstr(Text,7,7) ;
Print("----------------- Start --------------" + val);
// val = DoubleToStr(NormalizeDouble(strPrice,5),4);
ObjectCreate(line_title, OBJ_HLINE, 0, 0, StrToDouble(val));
ObjectSet(line_title, OBJPROP_COLOR, Col);
ObjectSet(line_title, OBJPROP_WIDTH, 1);
ObjectSet(line_title, OBJPROP_STYLE, STYLE_SOLID);
Print("----------------- End --------------");
}
}
return;
}

Quoting RaptorUK

Disliked

Doesn't this explain it all ?

string strPrice = StringSubstr(subText,0,posComa) ;

string DoubleToStrPrice = DoubleToStr( NormalizeDouble( strPrice, 5) ,4);

Why are you calling NormalizeDouble() with a string ?

Ignored

Thanks I got my mistake. Thanks for help

#1,697
Feb 26, 2013 9:57pm Feb 26, 2013 9:57pm

mpradeep
| Joined Apr 2012 | Status: Trader | 168 Posts

Quoting kis

Disliked

Hi,

Since how long are you testing it? What are the results? What was the maximum DD?

Ignored

Hi i am using this since 4 months in jpy pair. Drawdown is 5 to 10%. working fine .sometimes i close in less profit. Please make this EA.

thank you

#1,698
Feb 27, 2013 12:33am Feb 27, 2013 12:33am

skld
| Joined Dec 2010 | Status: Trader | 42 Posts

would like to look at this code too?
i trued at myltiple brokers but it doesnot work
its a swap strategy version 2 with 5 digits from the same author

if it req. some files: they can be found at post
http://forex-strategies-revealed.com/mt4/swingstrategy

Attached File(s)

SWAP.mq4 18 KB | 472 downloads

#1,699
Feb 27, 2013 3:15am Feb 27, 2013 3:15am

RaptorUK
Joined Jan 2008 | Status: Trader | 870 Posts

Quoting skld

Disliked

would like to look at this code too?
i trued at myltiple brokers but it doesnot work
its a swap strategy version 2 with 5 digits from the same author

if it req. some files: they can be found at post
http://forex-strategies-revealed.com/mt4/swingstrategy

Ignored

That code won't work with an ECN type Broker, more info here: ECN

20 pips a day isn't too much to ask . . .

#1,700
Feb 27, 2013 3:49am Feb 27, 2013 3:49am

skld
| Joined Dec 2010 | Status: Trader | 42 Posts

Quoting RaptorUK

Disliked

That code won't work with an ECN type Broker, more info here: ECN

Ignored

thank you!

are you mt4 coder?

i will try to modify source code at evening after reading your article but possible i will need some help=)

ps . sorry for wrong link in last post

Platform Tech
/
I will code your EAs and Indicators for no charge
Reply to Thread
- 1 83 84 Page 85 86 87 4112
- 1 Page 85 4112

172 traders viewing now, 3 are registered:

mmurat

aspiring91

Invisible

Options

Similar Threads

I will code your EAs and Indicators for no charge