Detection of a new bar for an EA in mql4

Quoting Voldemar227

Disliked

The best method for determining a new bar is presented by me. It is important to take into account that with the arrival of a new bar a lot of advisers begin to trade, broker servers are under heavy load and get DOS attack trading programs. The broker server refuses and causes requotes and failures of trade. I recommend to use the time shift and define a new bar not at 00 : 00 but at 00: 05 seconds bool NewBar() { static datetime time=0; if(time==0) { time=Time[0]; return false; } if(time!=Time[0]) { time=Time[0]; return true; } return false; }

Ignored

//************************************************************************************************/
//                     Author of the new bar with shift function Voldemar227                     */
//                            https://www.forexfactory.com/voldemar227                           */
//************************************************************************************************/
bool NewBar(string aSymbol="", const ENUM_TIMEFRAMES aPeriod=PERIOD_CURRENT, const int aShiftSeconds=5)
  {
   if(aSymbol=="")
      aSymbol=Symbol();
   static datetime time    = 0;
   datetime        new_bar = (datetime)SeriesInfoInteger(aSymbol,aPeriod,SERIES_LASTBAR_DATE);
   if(time==0)
     {
      time=new_bar+PeriodSeconds(aPeriod);
      return false;
     }
   if((TimeCurrent()-time)>=aShiftSeconds)
     {
      time=new_bar+PeriodSeconds(aPeriod);
      return true;
     }
   return false;
  }
//************************************************************************************************/
//                                                                                               */
//************************************************************************************************/

Quoting Voldemar227

Disliked

Keep on health ! For MetaTrader 4 and MetaTrader 5 universal stable //************************************************************************************************/ // Author of the new bar with shift function Voldemar227 */ // https://www.forexfactory.com/voldemar227 */ //************************************************************************************************/ bool NewBar(const int aShiftSeconds=0) { static datetime time = 0; datetime new_bar = (datetime)SeriesInfoInteger(Symbol(),Period(),SERIES_LASTBAR_DATE); if(time==0)...

Ignored

Quoting Nicholishen

Disliked

{quote} Please forgive my criticisms, but this is method is fundamentally flawed due to Broker maintenance cycles when the market goes down at a scheduled time per day (eg. market closes at 22:00 reopens at 22:05UTC) Broker has not updated the tick feed, thus a new bar won't form until the next tick of after the time period for new bar (eg. no new tick for a few minutes after close of last period.) and therefore will falsely signal a new bar when one has not formed.

Ignored

Quoting Nicholishen

Disliked

{quote} Please forgive my criticisms, but this is method is fundamentally flawed due to Broker maintenance cycles when the market goes down at a scheduled time per day (eg. market closes at 22:00 reopens at 22:05UTC) Broker has not updated the tick feed, thus a new bar won't form until the next tick of after the time period for new bar (eg. no new tick for a few minutes after close of last period.) and therefore will falsely signal a new bar when one has not formed.

Ignored

Quoting Voldemar227

Disliked

{quote} The task of the function is to determine a new bar with a shift. Suggest a better option ?

Ignored

void OnTimer()
{
//---
   if(IsRecentClosed())
      Alert("CLOSED");
}
bool IsRecentClosed()
{
   static datetime last_closed = 0;
  
   if(last_closed == 0)
   {
      datetime time[];
      if(CopyTime(_Symbol,PERIOD_CURRENT,0,1,time) < 1)
         return false;
      printf("copied time of %s to array",TimeToString(time[0]));
      last_closed = time[0] - 1;
   }
      
   if(TimeCurrent() >= last_closed + PeriodSeconds(PERIOD_CURRENT))
   {
      last_closed+= PeriodSeconds(PERIOD_CURRENT);
      return true;
   }
   return false;
}

datetime LastActionTime;            //Declare this on the same section you declare inputs
 
void OnTick()
{
if(LastActionTime!=Time[0])       //At the begging the value of that variable is set to nothing, then the condition is true.
  {
    //So it would run your code, I recommend you to set a function that contains all the code for trading to make it easier to structure.
      
       LastActionTime = Time[0]; // Then, you set the variable value to the open time of the current candle, then when you test the if condition it will be the same and the code will not run
      }
                                               //When a new bar comes in, the value stored on the variable would correspond to the open time for the bar 1, and the condition would be true and then the code will run and set the flag to prevent to run again.

Quoting Voldemar227

Disliked

Keep on health ! For MetaTrader 4 and MetaTrader 5 universal stable //************************************************************************************************/ // Author of the new bar with shift function Voldemar227 */ // https://www.forexfactory.com/voldemar227 */ //************************************************************************************************/ bool NewBar(string aSymbol="", const ENUM_TIMEFRAMES aPeriod=PERIOD_CURRENT, const int aShiftSeconds=5) { if(aSymbol=="") aSymbol=Symbol(); static datetime...

Ignored