I will code your EAs and Indicators for no charge

Quoting honestknave

Disliked

{quote} Trust me, your code isn't doing what you think it is. To step back: BufferALL[] is an array with 2 slots.... Not 2 slots per bar.... Just 2 slots.... [0] and [1]. It isn't a buffer. Each slot will only store one value. Each time you write to it, you overwrite what was previously there. This code: int Timeframe[7][3]={15,,, 60,,, 240,,, 1440,,, 10080,,, 43200,,, ,,}; for(int i=0; i<=5; i++) { BufferALL[0]=iCustom("EURUSD",Timeframe[0],"ADX",14,0,i); } Is doing this: BufferALL[0]=iCustom("EURUSD",15,"ADX",14,0,0); BufferALL[0]=iCustom("EURUSD",60,"ADX",14,0,1);...

Ignored

Quoting Codix

Disliked

i know its not a buffer. I know it gets overwritten. After the Print command has printed the value in the Experts tab the value may be overwritten by the value of the next cycle. The same goes for BufferALL[1]. What i'm asking is, why don't the printed values per cycle ever change? Its like the symbol EURUSD is no longer updating. I'm talking about the values of iCustom(ADX.mq4).

Ignored

#property strict
#property indicator_chart_window
 
int OnInit()
  {
   EventSetTimer(30); // let's not spam the log
   OnTimer();
   return(INIT_SUCCEEDED);
  }
 
void OnDeinit(const int reason)
  {
   EventKillTimer();
  }
 
int OnCalculate(const int rates_total,
                const int prev_calculated,
                const datetime &time[],
                const double &open[],
                const double &high[],
                const double &low[],
                const double &close[],
                const long &tick_volume[],
                const long &volume[],
                const int &spread[])
  {
   return(rates_total);
  }
 
void OnTimer()
  {
   double ADX; // no need for an array
   int Timeframe[6]={1,5,15,30,60,240}; // no need to be multi-dimensional array
   for(int i=0; i<=5; i++)
     {
      ADX=iCustom("EURUSD",Timeframe[i],"ADX",14,0,i);
      string when=TimeToStr(iTime("EURUSD",Timeframe[i],i),TIME_MINUTES);
      printf("Bar %i on Period %3i  (%s)  ADX=%.1f",i,Timeframe[i],when,ADX);
     }
  }

Quote

Disliked

My second question was. Why does the internal function of ADX return an empty buffer value? The code of the internal ADX (converted to an internal function) is exactly the same as the code in ADX.mq4 that is being called externally. Why is this happening? Kind regards, Codix

Quoting MikeBilel

Disliked

Hi, I have a super super simple request (for coders). I found this BandsR2 Indicator and it's great! This is the only indicator I've found on the whole internet that alerts when a candle clips the Bollinger band. It is almost perfect. Just one issue: it won't shut up!! It keeps replaying the chosen .wav file every few seconds and it's driving me insane! The "AlarmDelay" setting sure as hell isn't working because I tried 50 and 200 seconds. No dice... I would really appreciate if somebody could take a look at this indicator and apply this fix! Thank...

Ignored

Quoting MikeBilel

Disliked

Hi, I have a super super simple request (for coders). I found this BandsR2 Indicator and it's great! This is the only indicator I've found on the whole internet that alerts when a candle clips the Bollinger band. It is almost perfect. Just one issue: it won't shut up!! It keeps replaying the chosen .wav file every few seconds and it's driving me insane! The "AlarmDelay" setting sure as hell isn't working because I tried 50 and 200 seconds. No dice... I would really appreciate if somebody could take a look at this indicator and apply this fix! Thank...

Ignored

if ((Close[] >=BB1) && (AlertPlayedonBar != Bars)) | ((Close[] <=BB2) && (AlertPlayedonBar1 != Bars)) { Alert("bb hit!");
AlertPlayedonBar = Bars;}

Quoting honestknave

Disliked

{quote} The values should update OK. Remember the only value to change regularly will be the first print statement (shift 0). All the other values are historical bars (shifts 1 to 5) and therefore will only change on bar change. As some of your timeframes are very large, that will take some time to happen. Here is a stripped out version as an example - load it up and you'll see the Bar 0 value changes most calls. The other values only change when a bar changes: #property strict #property indicator_chart_window int OnInit() { EventSetTimer(30); //...

Ignored

Quoting honestknave

Disliked

{quote} Trust me, your code isn't doing what you think it is. To step back: BufferALL[] is an array with 2 slots.... Not 2 slots per bar.... Just 2 slots.... [0] and [1]. It isn't a buffer. Each slot will only store one value. Each time you write to it, you overwrite what was previously there. This code: int Timeframe[7][3]={15,,, 60,,, 240,,, 1440,,, 10080,,, 43200,,, ,,}; for(int i=0; i<=5; i++) { BufferALL[0]=iCustom("EURUSD",Timeframe[0],"ADX",14,0,i); } Is doing this: BufferALL[0]=iCustom("EURUSD",15,"ADX",14,0,0); BufferALL[0]=iCustom("EURUSD",60,"ADX",14,0,1);...

Ignored

   for(i=0; i<limit; i++){
      ADXBuffer[i]=iMAOnArray(TempBuffer,iBars(symbool,tijd),ADXPeriod,0,MODE_EMA,i);

Quoting Codix

Disliked

Notice that the code of the ADX internal function is exactly the same as the code of the external ADX thats being called with iCustom. Yet all the internalized ADX function returns is the empty value of ADXBuffer[0]. Could you tell me why this is happening? All the code is exactly the same, so why does it return an empty value?

Ignored

Quoting Codix

Disliked

{quote} Please look at the screenshot: I get the error: "Indicator on custom buffer is not supported yet". This is what i get when i add the line Print(ADXBuffer[i]); to the for(i=0; i<limit; i++){ ADXBuffer[i]=iMAOnArray(TempBuffer,iBars(symbool,tijd),ADXPeriod,0,MODE_EMA,i); loop. I cnnot find anything about this error on the internet. Please help.

Ignored

Quoting alifari

Disliked

I would like to request some modification to attached indicator "Quick ZigZag Indi Version" posted by Hayseed. The current version show combined average zig zag length based of a particular time frame on any desired zig zag setting such as 12,5,3 etc. Modification Required 1) Instead of taking zig zag length from beginning, I want an option to see average zig zag length of last 10 swings only. So I need an additional parameter to see # of swings 2) Currently average zig zag length is showing combined average length of both up and down swings, but...

Ignored

Quoting honestknave

Disliked

{quote} But they aren't the same, and that's the problem I think. When you parsed the ADX code into a function, you mostly changed Bars to iBars. ADX needs to populate arrays for its calculations and so (quite rightly) the indicator makes use of IndicatorCounted() to cut down the workload. IndicatorCounted() references the current chart. But you're feeding it the bar count from another timeframe, so everything goes a bit wrong. Without doing a great deal of fault finding (which I'm not going to do because you've already said you aren't actually...

Ignored

Quoting Codix

Disliked

{quote} hi honestknave, When i remove the IndicatorCounted() part the problem still persists. But since you (or anyone else for that matter) doesen't know what the error "Indicator on custom buffer is not supported yet" means, i take it the predefined function OnTimer has something to do with it. Mt4 truely is like a big black box that sometimes behaves in mysterious ways because metaquotes doesen't care to explain everything about the terminal in full detail. I am no longer going to try and internalize all the external indicators and I would like...

Ignored